Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support for versioning v2 on GitHub resource linking #4015

Merged
merged 2 commits into from
May 24, 2024

Conversation

novakzaballa
Copy link
Contributor

@novakzaballa novakzaballa commented May 23, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add support for versioning v2 on GitHub integration

How did you test this code?

There are unit tests already in place

Copy link

vercel bot commented May 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 5:22am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 5:22am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 5:22am

@github-actions github-actions bot added the api Issue related to the REST API label May 23, 2024
Copy link
Contributor

github-actions bot commented May 23, 2024

Uffizzi Preview deployment-52211 was deleted.

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.28%. Comparing base (59ddfba) to head (64ef8eb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4015   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files        1143     1143           
  Lines       36992    37012   +20     
=======================================
+ Hits        35618    35638   +20     
  Misses       1374     1374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@novakzaballa novakzaballa requested review from a team and matthewelwell and removed request for a team May 23, 2024 23:09
@novakzaballa novakzaballa changed the title feat: Add support for versioning v2 on GitHub integration fix: Add support for versioning v2 on GitHub resource linking May 23, 2024
@novakzaballa novakzaballa added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit edb4a75 May 24, 2024
24 checks passed
@novakzaballa novakzaballa deleted the feat/support-versioning-v2-for-gh-integration branch May 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants