feat(versioning): add logic to create version in single endpoint #3991
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
api/tests/unit/features/versioning/test_unit_versioning_views.py
Outdated
Show resolved
Hide resolved
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3991 +/- ##
==========================================
+ Coverage 96.44% 96.54% +0.10%
==========================================
Files 1149 1177 +28
Lines 37575 38507 +932
==========================================
+ Hits 36238 37176 +938
+ Misses 1337 1331 -6 ☔ View full report in Codecov by Sentry. |
…ate-in-single-endpoint
…ate-in-single-endpoint # Conflicts: # api/features/versioning/serializers.py # api/features/versioning/views.py
…ate-in-single-endpoint
…tead of feature states
|
I've now tested this PR against the FE branch here and confirmed that everything seems to work well. I used the Uffizzi deployment to do this too which was a good test latency-wise because the Uffizzi deployment runs somewhere in the US. It was noticeable that the latency was greatly improved when changing the state of the flag compared even to making a change in production SaaS from London. |
matthewelwell
deleted the
feat(versioning)/add-logic-to-create-in-single-endpoint
branch
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This PR updates the endpoint to create a new version to add new attributes that allow you to create, update and delete feature states when creating the new version and optionally publish it immediately. This will avoid the FE having to create the version, retrieve the feature states, update any necessary feature states and then publish it.
I'm keen to get feedback on the naming of the new fields as I'm not 100% pleased with them. The endpoint looks like this:
How did you test this code?
Added tests to cover all the use cases.