Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(versioning): ensure that future scheduled changes are migrated to versioning v2 #3958

Merged

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ensure that future scheduled change requests are correctly migrated to feature versioning v2.

How did you test this code?

Added comprehensive unit test.

@matthewelwell matthewelwell requested review from a team and novakzaballa and removed request for a team May 15, 2024 14:09
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 2:09pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 2:09pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 2:09pm

@github-actions github-actions bot added the api Issue related to the REST API label May 15, 2024
Copy link
Contributor

github-actions bot commented May 15, 2024

Uffizzi Preview deployment-51765 was deleted.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.01%. Comparing base (0ed5148) to head (28a772f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3958   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files        1135     1135           
  Lines       36401    36435   +34     
=======================================
+ Hits        34950    34984   +34     
  Misses       1451     1451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthewelwell matthewelwell enabled auto-merge May 16, 2024 07:51
@matthewelwell matthewelwell added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit c5aa610 May 16, 2024
24 checks passed
@matthewelwell matthewelwell deleted the fix(versioning)/handle-scheduled-change-requests branch May 16, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants