Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: send all users on paid subscriptions to hubspot #3902

Merged
merged 1 commit into from
May 8, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Previously we filtered out users that were part of an organisation that had a paid subscription before sending them to hubspot. This PR removes that filtering.

How did you test this code?

I haven't, but it's just removing a few lines of trivial code which gets called in a single location.

@matthewelwell matthewelwell requested a review from zachaysan May 8, 2024 16:19
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 4:22pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 4:22pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 4:22pm

Copy link
Contributor

github-actions bot commented May 8, 2024

Uffizzi Preview deployment-51461 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (001788b) to head (e7d0cdb).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3902      +/-   ##
==========================================
+ Coverage   95.87%   95.92%   +0.05%     
==========================================
  Files        1134     1134              
  Lines       36009    35956      -53     
==========================================
- Hits        34522    34492      -30     
+ Misses       1487     1464      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we should have had test coverage for this.

@matthewelwell matthewelwell added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 0c79870 May 8, 2024
22 checks passed
@matthewelwell matthewelwell deleted the fix/send-all-leads-including-paid-subs branch May 8, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants