fix: update secrets location for GITHUB_PEM #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
khvn26
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khvn26
approved these changes
May 1, 2024
|
Uffizzi Preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
In order to store / read the Private Key for the Github integration, it was necessary to store it in its own secret, rather than the JSON formatted secret which stores the rest of the secrets for the API.
The alternative (which I did consider) was to base64 encode the private key and then decode it in when we load it from the environment variable, but I figured that to be overkill.
How did you test this code?
I updated the task definition in staging manually and confirmed that the deployment succeeded.