fix: use ENABLE_FLAGSMITH_REALTIME environment var #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
front-end
|
Since it's I'm also renaming the PR title to |
khvn26
changed the title
|
Uffizzi Preview |
matthewelwell
approved these changes
May 1, 2024
This env var is read from vercel in our SaaS environments so we just need to make sure it's set there. |
|
Yeah it was all in vercel already |
kyle-ssg
commented
May 1, 2024
| { | ||
| "name": "ENABLE_FLAGSMITH_REALTIME", | ||
| "value": "True" | ||
| }, |
There was a problem hiding this comment.
I don't think we need this, unless I'm missing a usecase? Config gets to FE via Vercel.
khvn26
force-pushed
the
chore/enable-flagsmith-realtime-environment-var
branch
from
d0214cc to
6d9cd54
Compare
khvn26
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
ENABLE_FLAGSMITH_REALTIME was setup to determine if the SDK initialised with the realtime boolean. For some reason this was not used in the admin panel.
Demo and production Vercel environments already provide this to the FE.
How did you test this code?
Project.flagsmithRealtimeis being set.