feat: sort by Overage in sales dashboard #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3858 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 1129 1130 +1
Lines 35787 35791 +4
=======================================
+ Hits 34309 34313 +4
Misses 1478 1478 ☔ View full report in Codecov by Sentry. |
zachaysan
approved these changes
Apr 30, 2024
| @@ -44,7 +44,8 @@ <h1 class="h2">Organisations</h1> | |||
| <option value="num_features" {% if sort_field == "num_features" %}selected{% endif %}>Flags</option> | |||
| <option value="subscription_information_cache__api_calls_24h" {% if sort_field == "subscription_information_cache__api_calls_24h" %}selected{% endif %}>24h API calls</option> | |||
| <option value="subscription_information_cache__api_calls_7d" {% if sort_field == "subscription_information_cache__api_calls_7d" %}selected{% endif %}>7d API calls</option> | |||
| <option value="subscription_information_cache__api_calls_30d" {% if sort_field == "subscription_information_cache__api_calls_30d" or not sort_field %}selected{% endif %}>30d API calls</option> | |||
| <option value="subscription_information_cache__api_calls_30d" {% if sort_field == "subscription_information_cache__a pi_calls_30d" or not sort_field %}selected{% endif %}>30d API calls</option> | |||
There was a problem hiding this comment.
I don't understand what subscription_information_cache__a does here. I understand it's part of a sort field, but what is the __a portion from the cache represent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Allows sorting by Overage in the sales dashboard organisation list view.
We're changing the view's query set to use a calculated
overagefield instead of theget_api_call_overagemethod. In my local environment, this adds the following column to the result set:How did you test this code?
Manually in a local environment. I have not tested this with a large number of organisations, but also don't foresee any issues.
This individual test can be run with
pytest tests/unit/sales_dashboard.