fix(versioning): prevent deleted segment overrides returning #3850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
khvn26
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3850 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 1130 1131 +1
Lines 35795 35834 +39
=======================================
+ Hits 34315 34354 +39
Misses 1480 1480 ☔ View full report in Codecov by Sentry. |
5 tasks
khvn26
approved these changes
May 1, 2024
api/tests/unit/features/versioning/test_unit_versioning_versioning_service.py
Outdated
Show resolved
Hide resolved
…sioning # Conflicts: # api/tests/unit/features/test_unit_features_views.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
This PR sets out to resolve a bug in the v2 versioning which meant that deleted segment overrides from older versions were being returned alongside other feature states in more recent versions.
This is achieved by grabbing the latest version for each feature in a given environment upfront and using this to filter the feature states.
Some notes on the specifics of this PR:
versioning_servicemodule and this is something that I'd like to work on refactoring, but if possible I'd like to do that after merging this PR so we can continue with testing.annotatein the Django ORM but I couldn't get it to work, if the reviewer has any suggestions, I'm all ears!How did you test this code?
Added tests.