fix: prevent unauthorised remove-users access #3791
Merged
+75
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
khvn26
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3791 +/- ##
=======================================
Coverage 95.91% 95.92%
=======================================
Files 1102 1103 +1
Lines 34789 34822 +33
=======================================
+ Hits 33369 33403 +34
+ Misses 1420 1419 -1 ☔ View full report in Codecov by Sentry. |
khvn26
requested changes
Apr 17, 2024
|
|
||
| organisation_id = view.kwargs.get("pk") | ||
| if organisation_id and not organisation_id.isnumeric(): | ||
| raise APIException("Invalid organisation ID") |
There was a problem hiding this comment.
This assumes the 500 status code. Why not use ValidationError instead?
There was a problem hiding this comment.
Whoops yep good catch, I wanted 400.
| @@ -1797,3 +1797,49 @@ def test_doesnt_retrieve_stale_api_usage_notifications( | |||
| # Then | |||
| assert response.status_code == status.HTTP_200_OK | |||
| assert len(response.data["results"]) == 0 | |||
|
|
|||
There was a problem hiding this comment.
Add a test for non-numeric org id.
khvn26
reviewed
Apr 17, 2024
khvn26
reviewed
Apr 17, 2024
khvn26
approved these changes
Apr 17, 2024
matthewelwell
deleted the
fix/prevent-non-org-admin-users-from-removing-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Prevents unauthorised users from removing users from a given organisation.
How did you test this code?
Added unit tests.