Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(permissions): manage permissions from a single location #3730

Merged
merged 49 commits into from
Apr 26, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Apr 8, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Organisation, project and environment settings can be managed in a single place for users, groups and roles
  • Edit permissions happens without needing to press save (suggested in UX audit). This will start becoming a standard pattern with settings.
  • All users, regardless of their role can access the permissions screen, they can manage whatever they are admin of (e.g.permissions for a group on an environment they are admin of)
  • Previously, you had to navigate to separate areas to manage a group's users and their permissions, this is now combined
  • Create / updating group no longer requires a refresh
  • Dev experience: Migrates all groups functionality and OrganisationProvider to TypeScript/RTK
  • Dev experience: Removes /organisation-groups, this was a page we showed specifically for MANAGE_GROUPS users, it is no longer needed.
  • Minor: Improves user list ui
  • Minor: Toast messages no longer show duplicate consecutive messages
check.admin.permissions.mov

How I tested

  • Created / edited a group
  • Managed organisation, project and environment permissions as an org admin
  • Checked I couldn't edit permissions as a group admin without org permissions
  • Made group admin a project admin, checked that they could manage permissions but just for that project

kyle-ssg and others added 30 commits March 20, 2024 20:02
# Conflicts:
#	frontend/common/types/requests.ts
# Conflicts:
#	frontend/web/components/UserGroupList.tsx
# Conflicts:
#	frontend/common/services/useRolePermission.ts
#	frontend/common/types/requests.ts
#	frontend/web/components/EditPermissions.tsx
#	frontend/web/components/RolePermissionsList.tsx
#	frontend/web/components/RolesTable.tsx
#	frontend/web/components/UserGroupList.tsx
#	frontend/web/components/modals/CreateRole.tsx
#	frontend/web/components/pages/OrganisationSettingsPage.js
#	frontend/web/project/project-components.js
# Conflicts:
#	frontend/common/stores/organisation-store.js
#	frontend/web/components/FeatureAction.tsx
@kyle-ssg
Copy link
Member Author

Yep correct, remove-users calls were missing. I've since tested adding and removing group users.

@matthewelwell
Copy link
Contributor

matthewelwell commented Apr 24, 2024

Sorry, I think this is probably the last issue but it looks like we've lost the tags that we had previously on each of the entities that gave a summary of what permission a user had on that entity without having to open it up.

This preview:

image

Current production:

image

# Conflicts:
#	frontend/common/types/requests.ts
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kyle-ssg this looks good now (and seems to include the fix we talked about yesterday regarding showing the groups in a project settings) but I've updated the title of the PR as I don't think it should be a chore.

@matthewelwell matthewelwell changed the title chore: Improve groups and permissions feat(permissions): manage permissions from a single location Apr 26, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit fc34a53 Apr 26, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the chore/combine-group-settings branch April 26, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
2 participants