-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permissions): manage permissions from a single location #3730
Conversation
Co-authored-by: Zach Aysan <[email protected]>
…bine-group-settings
# Conflicts: # frontend/common/types/requests.ts
# Conflicts: # frontend/web/components/UserGroupList.tsx
# Conflicts: # frontend/common/services/useRolePermission.ts # frontend/common/types/requests.ts # frontend/web/components/EditPermissions.tsx # frontend/web/components/RolePermissionsList.tsx # frontend/web/components/RolesTable.tsx # frontend/web/components/UserGroupList.tsx # frontend/web/components/modals/CreateRole.tsx # frontend/web/components/pages/OrganisationSettingsPage.js # frontend/web/project/project-components.js
# Conflicts: # frontend/common/stores/organisation-store.js # frontend/web/components/FeatureAction.tsx
Yep correct, remove-users calls were missing. I've since tested adding and removing group users. |
# Conflicts: # frontend/common/types/requests.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kyle-ssg this looks good now (and seems to include the fix we talked about yesterday regarding showing the groups in a project settings) but I've updated the title of the PR as I don't think it should be a chore.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
check.admin.permissions.mov
How I tested