feat: Clone identities (FE) #3725
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
|
Uffizzi Preview |
frontend/common/types/responses.ts
Outdated
| @@ -287,6 +287,7 @@ export type IdentityFeatureState = { | |||
| enabled: boolean | |||
| feature_state_value: FlagsmithValue | |||
| segment: null | |||
| overridden_by: string | |||
There was a problem hiding this comment.
I'm guessing this is string|null
| return openConfirm({ | ||
| body: ( | ||
| <div> | ||
| {'Are you sure you want to clone all the feature states from '} |
There was a problem hiding this comment.
Does cloning clone overrides and traits?
If so I think that might read better
"Cloning an identity will copy any traits and identity overrides. Are you sure?"
There was a problem hiding this comment.
We don't clone the traits.
Maybe could be: "Cloning {identityA} will copy any identity overrides in {identityB}. Are you sure?"
| toast('Clonation Completed!') | ||
| }) | ||
| }, | ||
| title: 'Clone the values', |
There was a problem hiding this comment.
Clone identity might be better here ? Not clear what "The values" means
| }} | ||
| className='ms-2 me-2' | ||
| > | ||
| {'Clone features states'} |
There was a problem hiding this comment.
Clone identity overrides I think?
There was a problem hiding this comment.
This text was updated.
| </Button> | ||
| } | ||
| > | ||
| {`Clone the features states from ${leftId?.label} to ${rightId?.label}`} |
There was a problem hiding this comment.
this text was updated.
| @@ -120,6 +127,38 @@ const CompareIdentities: FC<CompareIdentitiesType> = ({ | |||
| ) | |||
| } | |||
|
|
|||
| const clonedentityValues = ( | |||
There was a problem hiding this comment.
Good catch, was corrected
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Please describe.