Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: async feature versioning test #3717

Merged
merged 13 commits into from
Apr 4, 2024
Merged

fix: async feature versioning test #3717

merged 13 commits into from
Apr 4, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Apr 4, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

We had intermittent failures in the versioning test, there are 2 reasons why this would happen

  • The action to enable an environment versioning is async, it could take a while to process
  • The frontend was incorrectly saving the environment when the feature was enabled

@vercel Vercel
Copy link

vercel bot commented Apr 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 1:19pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 1:19pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 1:19pm

@kyle-ssg kyle-ssg requested a review from novakzaballa April 4, 2024 08:45
@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 4, 2024
@kyle-ssg kyle-ssg linked an issue Apr 4, 2024 that may be closed by this pull request
Locally and sometimes in the e2e tests, the value of use_v2_feature_versioning does not update from false to true when you enable this feature. #3712
Closed
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024 •
edited
Loading

Uffizzi Preview deployment-49469 was deleted.

@github-actions github-actions bot added the github label Apr 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (d5f76ff) to head (e464f24).
Report is 2 commits behind head on main.

❗ Current head e464f24 differs from pull request most recent head 492e532. Consider uploading reports for the commit 492e532 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3717   +/-   ##
=======================================
  Coverage   95.89%   95.89%           
=======================================
  Files        1101     1101           
  Lines       34681    34681           
=======================================
  Hits        33256    33256           
  Misses       1425     1425

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

novakzaballa
novakzaballa approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some test are now failing.

@kyle-ssg kyle-ssg enabled auto-merge April 4, 2024 13:40
@kyle-ssg kyle-ssg requested a review from novakzaballa April 4, 2024 13:40
novakzaballa
novakzaballa approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyle-ssg kyle-ssg added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 8ad7f04 Apr 4, 2024
21 checks passed
@kyle-ssg kyle-ssg deleted the chore/fix-async-versioning-test branch April 4, 2024 13:42
@dabeeeenster dabeeeenster mentioned this pull request Apr 4, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
4 participants
@kyle-ssg @codecov-commenter @novakzaballa @matthewelwell