feat: Support multiple OR'd search terms in sales-dashboard #3715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
This naive-ish implementation splits search terms by commas and ORs them all together. This has implications on any existing search queries:
ACME, LLC
will now search forACME
ORLLC
, whereas today it's an exact match. This will return the same results as before, in addition to potentially other unrelated results,
as a search criterion - I don't think this mattersGiven the internal scope of the sales dashboard and the value of allowing multiple search queries, I think the tradeoff for this change is worth it. This seems like a good 80/20 solution.
Example (searching for multiple queries):
How did you test this code?
Manually on a local instance, validated with manual testing.