Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multiple OR'd search terms in sales-dashboard #3715

Merged

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Apr 3, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Support searching by multiple terms in the Sales dashboard
  • Add text to the Search box placeholder to clarify what exactly is being searched:

image

This naive-ish implementation splits search terms by commas and ORs them all together. This has implications on any existing search queries:

  • ACME, LLC will now search for ACME OR LLC, whereas today it's an exact match. This will return the same results as before, in addition to potentially other unrelated results
  • It's now impossible to use , as a search criterion - I don't think this matters

Given the internal scope of the sales dashboard and the value of allowing multiple search queries, I think the tradeoff for this change is worth it. This seems like a good 80/20 solution.

Example (searching for multiple queries):

image

How did you test this code?

Manually on a local instance, validated with manual testing.

Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2024 7:04pm

Copy link

vercel bot commented Apr 3, 2024

@rolodato is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the api Issue related to the REST API label Apr 3, 2024
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Uffizzi Preview deployment-49441 was deleted.

Copy link
Member

@khvn26 khvn26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rolodato rolodato added this pull request to the merge queue Apr 3, 2024
Merged via the queue into Flagsmith:main with commit d5f76ff Apr 3, 2024
21 of 23 checks passed
@rolodato rolodato deleted the sales-dashboard-multiple-search-terms branch April 3, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants