feat: Add org id to hubspot company #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3680 +/- ##
=======================================
Coverage 95.84% 95.84%
=======================================
Files 1099 1099
Lines 34428 34428
=======================================
Hits 32999 32999
Misses 1429 1429 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Mar 27, 2024
| def create_company(self, name: str) -> dict: | ||
| properties = {"name": name} | ||
| def create_company(self, name: str, organisation_id: int) -> dict: | ||
| properties = {"name": name, "orgid": str(organisation_id)} |
There was a problem hiding this comment.
Minor: I'd love to see the hubspot parameters pulled out as constants in e.g. hubspot.constants.
There was a problem hiding this comment.
We discussed offline and decided against it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
On the creation of a Hubspot company resource include the
organsation_idin a new field which is titledOrgIDin Hubspot, but is only accessible viaorgidthrough the API due to restrictions on Hubspot's end.How did you test this code?
Manually checked the API response once I was able to set the param in all lowercase then updated an existing test that already checked for the right mocked call to a client resource.