fix: prevent tasks dying from temporary loss of db connection

[matthewelwell]

Changes

Fixes issue where threads die from a temporary loss of connection to the database by catching DatabaseError and logging.

How did you test this code?

Added a unit test to verify that the exception is handled and the correct logs are written.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 26, 2024 2:41pm
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 26, 2024 2:41pm
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 26, 2024 2:41pm

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 95.90%. Comparing base (21cc2d3) to head (e49b588).
Report is 6 commits behind head on main.

Files	Patch %	Lines
api/task_processor/threads.py	80.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3674      +/-   ##
==========================================
+ Coverage   95.86%   95.90%   +0.03%     
==========================================
  Files        1099     1100       +1     
  Lines       34422    34458      +36     
==========================================
+ Hits        33000    33047      +47     
+ Misses       1422     1411      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[khvn26]

LGTM.

I'd love to see a test with less mocking (e.g. with db fixture taken out), but it's probably not worth the hassle. In case of errors different than DatabaseError, we'll take it as it comes I guess.