-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Ability to customise default environments for new project #3655
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason for making this a flag vs an environment variable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but for some reason, several tests failed at the same place: AssertionError: waitForElementVisible([data-test="features-page"])
I ran the e2e tests locally, and they failed. |
c688458
to
83f8aac
Compare
Uffizzi Preview |
83f8aac
to
f2f0c6d
Compare
@matthewelwell I figured this setting is analogous to etc. TBH I'd move all settings to FoF if it was up to me, leveraging the offline mode for static/default values. |
@novakzaballa Found the error and fixed it! |
f2f0c6d
to
95b42ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I couldn't find the new flag default_environment_names_for_new_project
in prod.
@novakzaballa The default value will be used for SaaS. The flag is intended for private/self-hosted installations. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
This PR adds the
default_environment_names_for_new_project
FoF flag to customise default environment names when creating a new project.How did you test this code?
Ran the build locally.