Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Ability to customise default environments for new project #3655

Merged
merged 5 commits into from
Apr 22, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Mar 22, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This PR adds the default_environment_names_for_new_project FoF flag to customise default environment names when creating a new project.

How did you test this code?

Ran the build locally.

@khvn26 khvn26 requested review from a team and novakzaballa and removed request for a team March 22, 2024 16:54
Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 4:14pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 4:14pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 4:14pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates labels Mar 22, 2024
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for making this a flag vs an environment variable?

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but for some reason, several tests failed at the same place: AssertionError: waitForElementVisible([data-test="features-page"])

@novakzaballa
Copy link
Contributor

I ran the e2e tests locally, and they failed.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

Uffizzi Preview deployment-50361 was deleted.

@khvn26
Copy link
Member Author

khvn26 commented Apr 17, 2024

What was the reason for making this a flag vs an environment variable?

@matthewelwell I figured this setting is analogous to etc. segment_operators.

TBH I'd move all settings to FoF if it was up to me, leveraging the offline mode for static/default values.

@khvn26
Copy link
Member Author

khvn26 commented Apr 17, 2024

@novakzaballa Found the error and fixed it!

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I couldn't find the new flag default_environment_names_for_new_project in prod.

@khvn26
Copy link
Member Author

khvn26 commented Apr 22, 2024

@novakzaballa The default value will be used for SaaS. The flag is intended for private/self-hosted installations.

@khvn26 khvn26 added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit cfb5748 Apr 22, 2024
22 checks passed
@khvn26 khvn26 deleted the feat/custom-default-environments branch April 22, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation updates front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants