feat: Add domain to Hubspot company #3648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kyle-ssg
reviewed
Mar 24, 2024
matthewelwell
requested changes
Mar 25, 2024
Comment on lines
61
to
74
| def get_or_create_organisation_hubspot_id( | ||
| self, organisation: Organisation, user: FFAdminUser | ||
| ) -> str: | ||
| """ | ||
| Return the Hubspot API's id for an organisation. | ||
| """ | ||
| if getattr(organisation, "hubspot_organisation", None): | ||
| return organisation.hubspot_organisation.hubspot_id | ||
|
|
||
| response = self.client.create_company(name=organisation.name) | ||
| if user.email_domain in settings.HUBSPOT_IGNORE_ORGANISATION_DOMAINS: | ||
| domain = None | ||
| else: | ||
| domain = user.email_domain | ||
| response = self.client.create_company(name=organisation.name, domain=domain) |
There was a problem hiding this comment.
We should update the unit tests for this logic.
There was a problem hiding this comment.
Ok altered one existing test to capture when it is set and created a new test for when the domain name is in the filter list.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3648 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 1099 1099
Lines 34457 34490 +33
=======================================
+ Hits 33034 33066 +32
- Misses 1423 1424 +1 ☔ View full report in Codecov by Sentry. |
|
Uffizzi Preview |
matthewelwell
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Fixes #3626
Simple change to introduce adding domain to the Hubspot company model.
How did you test this code?
Since this change was purely against their API, I elected to just test it manually which was successful.