Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Hubspot lead tracking for Hubspot data #3647

Merged
merged 6 commits into from
Mar 28, 2024
Merged

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Mar 21, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #3625

Simple PR to add tracking a user's Hubspot id when the user is created.

How did you test this code?

In addition to using the API directly myself to ensure that it was working, I also added two minor checks in existing tests that were already present in the codebase.

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 0:34am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 0:34am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 0:34am

@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (87d2d52) to head (6b4a294).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3647   +/-   ##
=======================================
  Coverage   95.88%   95.89%           
=======================================
  Files        1100     1101    +1     
  Lines       34520    34536   +16     
=======================================
+ Hits        33101    33117   +16     
  Misses       1419     1419           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zachaysan zachaysan requested a review from matthewelwell March 25, 2024 14:35
Copy link
Contributor

github-actions bot commented Mar 27, 2024

Uffizzi Preview deployment-49052 was deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hubspot: Store contact id from hubspot against user
3 participants