fix: prevent cascade deletes from users deleting change requests #3580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
novakzaballa
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
front-end
matthewelwell
changed the title
|
Uffizzi Preview |
matthewelwell
changed the title
matthewelwell
requested review from
a team and
zachaysan
and removed request for
a team
gagantrivedi
approved these changes
Mar 8, 2024
matthewelwell
deleted the
fix(change-request)/prevent-fs-cascade-delete-for-change-request
branch
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Prevent cascade deletes on both feature states (from change requests) and change requests (from users). This prevents issues where users are deleted causing (potentially live) feature states from being deleted.
How did you test this code?
Ran the API locally with the workflows module integrated and manually generated a change request which had no user and verified that the FE handles the scenario well.