Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-keys): add has_expired to MasterAPIKey response #3432

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

matthewelwell
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Adds "has_expired" to MasterAPIKey serializer.

How did you test this code?

Added a new integration test.

@matthewelwell matthewelwell requested review from a team and zachaysan and removed request for a team February 16, 2024 12:48
Copy link

vercel bot commented Feb 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 16, 2024 0:52am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 0:52am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 0:52am

Copy link
Contributor

github-actions bot commented Feb 16, 2024

Uffizzi Preview deployment-46702 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d63a289) 95.92% compared to head (825006b) 95.92%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3432   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files        1090     1092    +2     
  Lines       33949    34003   +54     
=======================================
+ Hits        32564    32618   +54     
  Misses       1385     1385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell added this pull request to the merge queue Feb 16, 2024
Merged via the queue into main with commit 0a28ee0 Feb 16, 2024
22 of 23 checks passed
@matthewelwell matthewelwell deleted the feature(api-keys)/add-has-expired-property branch February 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants