fix(db): Fix read replica strategy

[matthewelwell]

Thanks for submitting a PR! Please check the boxes below:

• I have run pre-commit to check linting
• I have added information to docs/ if required so people know about the feature!
• I have filled in the "Changes" section below?
• I have filled in the "How did you test this code" section below?
• I have used a Conventional Commit title for this Pull Request

Changes

Fixes the logic to look for the actual enum instead of the value of the enum.

How did you test this code?

Updated the tests but also ran the API locally with REPLICA_DATABASE_URLS configured to point at a replicated database and confirmed that it worked as expected.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview		Feb 15, 2024 6:16pm
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 15, 2024 6:16pm
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 15, 2024 6:16pm

[khvn26]

Do we need to add a default setting value for the folks that have read replicas enabled?

[github-actions]

Uffizzi Preview deployment-46651 was deleted.

[matthewelwell]

Do we need to add a default setting value for the folks that have read replicas enabled?

The default is ReadReplicaStrategy.DISTRIBUTED, which maintains the previous behaviour.

[zachaysan]

I'm a little confused as to why the .value was added in the first place. I vaguely remember thinking it was necessary based on something.

[khvn26]

Do we need to add a default setting value for the folks that have read replicas enabled?

The default is ReadReplicaStrategy.DISTRIBUTED, which maintains the previous behaviour.

̶I̶t̶ ̶s̶h̶o̶u̶l̶d̶ ̶b̶e̶ ̶̶R̶e̶a̶d̶R̶e̶p̶l̶i̶c̶a̶S̶t̶r̶a̶t̶e̶g̶y̶.̶D̶I̶S̶T̶R̶I̶B̶U̶T̶E̶D̶.̶v̶a̶l̶u̶e̶̶ ̶s̶h̶o̶u̶l̶d̶n̶'̶t̶ ̶i̶t̶?̶ UPD It should not due to env.enum behaviour.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16a2468) 95.92% compared to head (025575c) 95.92%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3426   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files        1090     1090           
  Lines       33949    33949           
=======================================
  Hits        32564    32564           
  Misses       1385     1385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matthewelwell]

I'm a little confused as to why the .value was added in the first place. I vaguely remember thinking it was necessary based on something and I'm surprised that the test suite didn't caught it.

The test suite was essentially monkey patching the settings module to whatever it wanted, so the logic was sound when the setting was monkeypatched to be .value. The issue is that the tests weren't exercising the env.enum parsing logic which actually returns an instance of the enum class.