Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add create segment error handling #3413

Merged
merged 1 commit into from
Feb 13, 2024
Merged

fix: Add create segment error handling #3413

merged 1 commit into from
Feb 13, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Feb 13, 2024 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Adjusts the generic ErrorMessage component to accept RTK formatted errors
  • Adjusts create segment to pass request errors to the ErrorMessage component
image

How did you test this code?

  • Sent bad data to create segment

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 4:10pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 4:10pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 4:10pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 13, 2024
@kyle-ssg kyle-ssg linked an issue Feb 13, 2024 that may be closed by this pull request
Fix error handling in CreateSegment #3414
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2024 •
edited
Loading

Uffizzi Preview deployment-46480 was deleted.

zachaysan
zachaysan approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this so quickly Kyle!

@kyle-ssg kyle-ssg added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 932c62d Feb 13, 2024
19 checks passed
@kyle-ssg kyle-ssg deleted the fix/handle_create_segment_errors branch February 13, 2024 16:25
@dabeeeenster dabeeeenster mentioned this pull request Feb 13, 2024
Merged
@zachaysan zachaysan mentioned this pull request Feb 13, 2024
Merged
5 tasks
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaysan zachaysan zachaysan approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix error handling in CreateSegment
2 participants
@kyle-ssg @zachaysan