fix: Avoid errors when missing subscription information cache id #3380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3380 +/- ##
===========================================
- Coverage 95.93% 36.42% -59.52%
===========================================
Files 1077 1003 -74
Lines 32944 29008 -3936
===========================================
- Hits 31606 10565 -21041
- Misses 1338 18443 +17105 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Feb 5, 2024
matthewelwell
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingI have added information todocs/if required so people know about the feature!Changes
A Sentry issue alerted the ability of an unset subscription information cache id during an organisational delete. This code simply checks the presence of the model in question and does not delete it if the id is not present.
Though only three occurrences at the time of this writing have happened, it's not clear as to how the application got into the state where an model is set without an id.
How did you test this code?
I am going to rely on CI since the change is very simple.