Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex requirement display while creating a flag is white-on-white text #3375

Closed
1 of 4 tasks
strugee opened this issue Feb 2, 2024 · 0 comments · Fixed by #3394
Closed
1 of 4 tasks

Regex requirement display while creating a flag is white-on-white text #3375

strugee opened this issue Feb 2, 2024 · 0 comments · Fixed by #3394
Assignees
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard

Comments

@strugee
Copy link
Contributor

strugee commented Feb 2, 2024

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

When you go to create a flag and have the setting to require a regex match for the flag name enabled, the flag creation screen will show a notice about the regex requirement. However the actual regex is white-on-white text, making it impossible to read without opening the devtools. See screenshots.

Steps To Reproduce

  1. Go to https://app.flagsmith.com/project//settings
  2. Enter ^(preco|bx|ox|platform|eng)_.+$ as the regex
  3. Go to https://app.flagsmith.com/project/<project ID>/environment/<environment ID>/features (I used our dev environment but presumably it doesn't matter)
  4. Click "Create Feature"
  5. Notice that the text in the blue "Note" box appears to be cut off

Expected behavior

The regex is shown.

Note that if you open devtools and inspect the element, then disable the color: var(--bs-code-color); that's applied to the code selector, it works fine.

Screenshots

Screenshot 2024-02-02 at 16 45 44
@strugee strugee added the bug Something isn't working label Feb 2, 2024
@dabeeeenster dabeeeenster added the front-end Issue related to the React Front End Dashboard label Feb 3, 2024
@dabeeeenster dabeeeenster added this to the Front End ToDo milestone Feb 3, 2024
@kyle-ssg kyle-ssg linked a pull request Feb 7, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants