fix(audit): add details for override creation #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
requested review from
a team and
gagantrivedi
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
|
Tests that are failing for this looks unrelated 😕 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3359 +/- ##
=======================================
Coverage 95.93% 95.93%
=======================================
Files 1071 1071
Lines 32767 32841 +74
=======================================
+ Hits 31434 31505 +71
- Misses 1333 1336 +3 ☔ View full report in Codecov by Sentry. |
gagantrivedi
approved these changes
Feb 2, 2024
matthewelwell
deleted the
fix(audit)/add-details-for-override-creation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Adds logic to ensure that change details are included when an override (segment or identity) is created. Previously, the logic is such that only updates are tracked.
Since the only real use case where this is important is for creating overrides, I have restricted this functionality (using a parameter on the history model base class) to only the FeatureState model.
How did you test this code?
Added some integration tests.