Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More details in Project Settings view #3333

Open
dabeeeenster opened this issue Jan 25, 2024 · 15 comments · Fixed by #3629
Open

More details in Project Settings view #3333

dabeeeenster opened this issue Jan 25, 2024 · 15 comments · Fixed by #3629
Assignees
Labels
front-end Issue related to the React Front End Dashboard improvement Improvement to the existing platform

Comments

@dabeeeenster
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In the Project Settings view for a project, when you look at "Members", it is possible to distinguish between Regular Users and Project Administrators. However, you can not see the same for a group.

Describe the solution you'd like.

When you look at the group list, we should add a column for whether the group is a Project Administrator or Regular Group.

In addition, it would be really helpful, in the same list view, to see for each user/group if that user/group have any project permissions (View, Create, Delete, Manage, etc.) without having the click on each user or group.

Describe alternatives you've considered

None

Additional context

No response

@dabeeeenster dabeeeenster added improvement Improvement to the existing platform front-end Issue related to the React Front End Dashboard labels Jan 25, 2024
@kyle-ssg
Copy link
Member

kyle-ssg commented Jan 29, 2024

In the Project Settings view for a project, when you look at "Members", it is possible to distinguish between Regular Users and Project Administrators. However, you can not see the same for a group.

@dabeeeenster This isn't true, we only distinguish between organisation administrators and normal users but nothing about project permissions.

image

I'm not sure whether we'd need to adjust the designs for this, would we want to show a list of permissions or perhaps Organisation Administrator | Project Administrator | Environment Administrator | x permissions / permission 1, permission 2

@dabeeeenster
Copy link
Contributor Author

Yes I think here
image

we should show a list of what permissions that group has.

@jatingodnani
Copy link

jatingodnani commented Feb 13, 2024

@matthewelwell is this issue open?

@kyle-ssg
Copy link
Member

@jatingodnani absolutely, if you're offering to pick this up! I'll probably be picking this up in around a week if not.

@jatingodnani
Copy link

@kyle-ssg woulb you like to explain me more about this issue

@kyle-ssg
Copy link
Member

@jatingodnani sure.

Essentially in the area Ben mentioned show the following if they are admin of that project/environment

Project Administrator

If they are not, we can show their permissions but truncate to the first 3 as tags e.g.

View Feature, Edit feature, Create Change request, +2 more 

@fabricanva
Copy link
Contributor

Hi there! I noticed this open issue and I'm interested in working on it. Would it be possible for someone to assign it to me?

@dabeeeenster dabeeeenster assigned fabricanva and unassigned kyle-ssg Mar 15, 2024
@dabeeeenster
Copy link
Contributor Author

Great thanks - its done!

@fabricanva
Copy link
Contributor

Thank you @dabeeeenster, I have submitted a PR for this: #3629

@fabricanva
Copy link
Contributor

I noticed that in the editPermission file, RTK query is not being used for certain requests (such as creating and updating a group). This could prevent the group and user lists from updating when such changes occur. Would it be advisable for me to create an issue regarding this?

@dabeeeenster
Copy link
Contributor Author

I noticed that in the editPermission file, RTK query is not being used for certain requests (such as creating and updating a group). This could prevent the group and user lists from updating when such changes occur. Would it be advisable for me to create an issue regarding this?

Q for @kyle-ssg and @novakzaballa !

@dabeeeenster dabeeeenster linked a pull request Mar 18, 2024 that will close this issue
5 tasks
@kyle-ssg
Copy link
Member

kyle-ssg commented Mar 26, 2024

@fabricanva you're exactly right, I have a couple of PRs in progress migrating things to RTK - related issue #3619

@kyle-ssg
Copy link
Member

kyle-ssg commented Mar 26, 2024

Reopening as this was progressed in #3629 (thank you so much) but still needs to be done for users

@fabricanva
Copy link
Contributor

Reopening as this was progressed in #3629 (thank you so much) but still needs to be done for users

No problem, I can implement it if you'd like @kyle-ssg 😁

@matthewelwell
Copy link
Contributor

@fabricanva apologies that no one got back to you here. If you're still interested in doing this work, we'd love for you to take it on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard improvement Improvement to the existing platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants