Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle feature import processing during import #3305

Merged
merged 4 commits into from
Jan 18, 2024

Conversation

zachaysan
Copy link
Contributor

@zachaysan zachaysan commented Jan 17, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This change stops people from uploading multiple feature imports at the same time and having them import in unexpected ways. It also trims the lifespan of how long a feature import or export can survive before it is culled into the failed category.

How did you test this code?

Some new tests with reasonable coverage.

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 7:18pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Jan 17, 2024 7:18pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 7:18pm

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Uffizzi Preview deployment-44537 was deleted.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaysan zachaysan added this pull request to the merge queue Jan 18, 2024
Merged via the queue into main with commit 28459c5 Jan 18, 2024
@zachaysan zachaysan deleted the fix/handle_feature_import_processing branch January 18, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants