Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Tidy up ld import #3276

Merged
merged 1 commit into from
Jan 15, 2024
Merged

fix: Tidy up ld import #3276

merged 1 commit into from
Jan 15, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Fixes an issue where the FE tries to get LD imports when no ID is specified
  • Fixes incorrect types
  • Adds missing imports

How did you test this code?

  • Validated LD imports are no longer fetched

@kyle-ssg kyle-ssg requested a review from novakzaballa January 11, 2024 14:17
@vercel Vercel
Copy link

vercel bot commented Jan 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 2:20pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 2:20pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 2:20pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 11, 2024 •
edited
Loading

Uffizzi Preview deployment-44191 was deleted.

@kyle-ssg kyle-ssg enabled auto-merge January 15, 2024 09:36
@kyle-ssg kyle-ssg added this pull request to the merge queue Jan 15, 2024
Merged via the queue into main with commit 3ee8e6a Jan 15, 2024
@kyle-ssg kyle-ssg deleted the fix/tidy-up-ld-import branch January 15, 2024 15:59
@dabeeeenster dabeeeenster mentioned this pull request Jan 15, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novakzaballa novakzaballa novakzaballa approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @novakzaballa