Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Segment Override" page shows an error if the control value is less than 0 for multi-variate flags. #3266

Closed
1 of 4 tasks
Dogacel opened this issue Jan 10, 2024 · 0 comments · Fixed by #3268
Closed
1 of 4 tasks

"Segment Override" page shows an error if the control value is less than 0 for multi-variate flags. #3266

Dogacel opened this issue Jan 10, 2024 · 0 comments · Fixed by #3268
Assignees
@kyle-ssg
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard

Comments

@Dogacel
Copy link
Contributor

Dogacel commented Jan 10, 2024

Describe the bug

Segment Override shows an error if the control value is less than 0

To Reproduce

Steps to reproduce the behavior:

  1. Create a multi-variate flag.
  2. Set the control value to something positive.
  3. Create a segment override.
  4. Set the control value to something negative.
  5. Check segment overrides page for error.

Expected behavior

Control values can be zero without showing an error.

Screenshots

Screen.Recording.2024-01-10.at.09.24.08.mov

How are you running Flagsmith?

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way

Additional context
@Dogacel Dogacel added the bug Something isn't working label Jan 10, 2024
@dabeeeenster dabeeeenster added the front-end Issue related to the React Front End Dashboard label Jan 10, 2024
@dabeeeenster dabeeeenster added this to the Front End ToDo milestone Jan 10, 2024
@kyle-ssg kyle-ssg linked a pull request Jan 10, 2024 that will close this issue
fix: variation percentage calculation #3268
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyle-ssg kyle-ssg

Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: variation percentage calculation Flagsmith/flagsmith
3 participants
@dabeeeenster @Dogacel @kyle-ssg