Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement feature actions dropdown #3253

Merged
merged 4 commits into from
Jan 11, 2024
Merged

feat: implement feature actions dropdown #3253

merged 4 commits into from
Jan 11, 2024

Conversation

azaiko-akveo
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

On the Features page:

  • "Remove feature" and "Show history" buttons were removed
  • Removed actions are displayed as items of actions dropdown
  • New action was added: "Copy Feature Name"

How did you test this code?

Run application locally

@vercel Vercel
Copy link

vercel bot commented Jan 8, 2024

@azaiko-akveo is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 8, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:36am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:36am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 10:36am

@azaiko-akveo azaiko-akveo marked this pull request as draft January 8, 2024 15:48
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024 •
edited
Loading

Uffizzi Preview deployment-43973 was deleted.

@azaiko-akveo azaiko-akveo marked this pull request as ready for review January 8, 2024 17:15
@dabeeeenster
Copy link
Contributor

The Figma has square icons:

image

but the HTML look squashed?

image

@azaiko-akveo
Copy link
Contributor Author

The Figma has square icons:

image but the HTML look squashed? image

fixed

@dabeeeenster dabeeeenster requested a review from kyle-ssg January 10, 2024 10:35
@dabeeeenster dabeeeenster added this to the Front End ToDo milestone Jan 10, 2024
@kyle-ssg kyle-ssg added this pull request to the merge queue Jan 11, 2024
Merged via the queue into Flagsmith:main with commit 972f1a3 Jan 11, 2024
@dabeeeenster dabeeeenster mentioned this pull request Jan 11, 2024
Merged
@kyle-ssg kyle-ssg linked an issue Jan 11, 2024 that may be closed by this pull request
Add option to copy feature name from dashboard and edit feature modal #2942
Closed
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

Assignees

@kyle-ssg kyle-ssg

Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to copy feature name from dashboard and edit feature modal
3 participants
@azaiko-akveo @dabeeeenster @kyle-ssg