-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make segment condition value dynamic #3245
feat: make segment condition value dynamic #3245
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3245 +/- ##
===========================================
- Coverage 95.96% 76.38% -19.59%
===========================================
Files 1062 1033 -29
Lines 32297 31254 -1043
===========================================
- Hits 30993 23872 -7121
- Misses 1304 7382 +6078 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small question / suggestion but overall the approach makes sense.
Changes
For self hosted customers, the limit on the length of each segment condition is very restrictive for little benefit. The restriction in our SaaS environment is primarily driven by the size limit that we have imposed on us by dynamodb (although hopefully this will be worked around in the not too distant future).
This PR allows self hosted customers to define the length of that column via an environment variable. I have added documentation warning against it's use for already running instances of Flagsmith.
How did you test this code?
Ran the following:
and validated the following:
Note that I also ran this to confirm that django doesn't think there are migrations to run (assuming the environment variable is not modified):