Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dynamo_documents): propagate delete to dynamo #3220

Merged
merged 14 commits into from
Jan 8, 2024
Merged

feat(dynamo_documents): propagate delete to dynamo #3220

merged 14 commits into from
Jan 8, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented Dec 26, 2023 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Add hooks/tasks to delete relevant documents from dynamo after they get deleted from core
ref: #1875

How did you test this code?

  • Adds/updates unit tests
  • Tested manually by creating/deleting all the relevant objects(org, project, environment, key, identity, identity-overrides) to make sure delete works

@vercel Vercel
Copy link

vercel bot commented Dec 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 3:37am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 3:37am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 3:37am

@github-actions github-actions bot added the api Issue related to the REST API label Dec 26, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 26, 2023 •
edited
Loading

Uffizzi Preview deployment-43526 was deleted.

@gagantrivedi gagantrivedi linked an issue Dec 26, 2023 that may be closed by this pull request
Delete Dynamo documents when they get deleted in core #1875
Closed
@gagantrivedi gagantrivedi force-pushed the fix/1875/delete-dynamo-docs branch from ec511af to c00a52c Compare December 27, 2023 09:43
@gagantrivedi gagantrivedi changed the title WIP: feat(environment_api_key): propagate delete to dynamo feat(environment_api_key): propagate delete to dynamo Dec 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023 •
edited
Loading

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a14eb23) 96.02% compared to head (078448f) 95.96%.
Report is 35 commits behind head on main.

Files Patch % Lines
...ironments/dynamodb/wrappers/environment_wrapper.py 89.83% 6 Missing ⚠️
api/environments/dynamodb/wrappers/base.py 93.54% 2 Missing ⚠️
...s/dynamodb/wrappers/environment_api_key_wrapper.py 93.75% 1 Missing ⚠️
...it/features/test_unit_features_features_service.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3220      +/-   ##
==========================================
- Coverage   96.02%   95.96%   -0.07%     
==========================================
  Files        1062     1066       +4     
  Lines       32219    32525     +306     
==========================================
+ Hits        30937    31211     +274     
- Misses       1282     1314      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gagantrivedi gagantrivedi marked this pull request as ready for review December 29, 2023 10:44
@gagantrivedi gagantrivedi changed the title feat(environment_api_key): propagate delete to dynamo feat(dynamo_documents): propagate delete to dynamo Jan 1, 2024
@gagantrivedi gagantrivedi requested a review from a team January 1, 2024 13:12
matthewelwell
matthewelwell reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, added quite a lot of comments here but they're mostly very minor!

gagantrivedi
gagantrivedi commented Jan 8, 2024
View reviewed changes
api/environments/dynamodb/wrappers/identity_wrapper.py
@@ -1,11 +1,9 @@
import logging
import typing
from contextlib import suppress
from typing import Any, Iterable
from typing import Iterable
Copy link
Member Author

@gagantrivedi gagantrivedi Jan 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is slightly misleading because it thinks the file was renamed(in reality it was broken down into multiple files)

@gagantrivedi gagantrivedi added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit b7ecd75 Jan 8, 2024
@gagantrivedi gagantrivedi deleted the fix/1875/delete-dynamo-docs branch January 8, 2024 12:10
@dabeeeenster dabeeeenster mentioned this pull request Jan 8, 2024
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@novakzaballa novakzaballa Awaiting requested review from novakzaballa novakzaballa is a code owner automatically assigned from Flagsmith/flagsmith-back-end

Assignees

@matthewelwell matthewelwell

Labels
api Issue related to the REST API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete Dynamo documents when they get deleted in core
3 participants
@gagantrivedi @codecov-commenter @matthewelwell