feat: Add new url for role master api keys #3215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
novakzaballa
changed the title
novakzaballa
changed the title
matthewelwell
approved these changes
Dec 22, 2023
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3215 +/- ##
==========================================
- Coverage 95.99% 95.99% -0.01%
==========================================
Files 1062 1062
Lines 32265 32299 +34
==========================================
+ Hits 30973 31005 +32
- Misses 1292 1294 +2 ☔ View full report in Codecov by Sentry. |
|
@novakzaballa this PR should also bump the RBAC version to 0.7.0 |
matthewelwell
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Add new URL for role's API keys.
GET: organisations/{organisation_pk}/roles-api-key/{prefix}/
Related with #3042 and https://github.com/Flagsmith/flagsmith-rbac/pull/14
How did you test this code?
The unit tests included in the RBAC PR: https://github.com/Flagsmith/flagsmith-rbac/pull/14