fix(versioning): endpoints should return latest versions #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewelwell
requested review from
a team and
khvn26
and removed request for
a team
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3209 +/- ##
==========================================
- Coverage 96.00% 96.00% -0.01%
==========================================
Files 1062 1063 +1
Lines 32200 32324 +124
==========================================
+ Hits 30914 31032 +118
- Misses 1286 1292 +6 ☔ View full report in Codecov by Sentry. |
zachaysan
reviewed
Dec 21, 2023
khvn26
approved these changes
Jan 3, 2024
matthewelwell
deleted the
fix(versioning)/endpoints-should-return-latest-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a FE integration issue and what appears to be a legitimate bug in the logic for getting the latest versions.
The FE integration issue was that the API to retrieve feature segments for a given environment / feature was previously returning the feature segments across all versions, rather than just the current live version as it currently does.
The legitimate bug was that, when evaluating the flags to retrieve the current live version, it was using the id of the feature segment as the unique key for a segment override whereas this changes for each version in the new versioning logic. As such, I have modified this logic to use the id of the segment which shouldn't change (at least until we start versioning segments too!).
Note that as part of this, I added a
tests.typesmodule. I also addedteststo theknown_first_partyattribute in isort configuration and hence there are a number of other file changes.How did you test this code?
Added unit tests which cover the specific functionality which exhibited the issues while integrating with the FE.