Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: prepopulate control value on segment overrides #3208

Merged
merged 1 commit into from
Dec 22, 2023
Merged

feat: prepopulate control value on segment overrides #3208

merged 1 commit into from
Dec 22, 2023
+4 −455

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Dec 21, 2023 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • When creating a segment override, the value input will be populated with the control value by default. This is really useful when overriding JSON/long fields.
  • Minor: removes rogue comma
    image
  • Removed a file that was completely unused

Please describe.

How did you test this code?

  • E2E Covers a lot of segment override creation
  • Added a segment override for the announcement feature.

@vercel Vercel
Copy link

vercel bot commented Dec 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 1:26pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview Dec 21, 2023 1:26pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 21, 2023 1:26pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Dec 21, 2023
@kyle-ssg kyle-ssg changed the title Prepopulate control value on segment overrides chore: Prepopulate control value on segment overrides Dec 21, 2023
@kyle-ssg kyle-ssg changed the title chore: Prepopulate control value on segment overrides improvement: Prepopulate control value on segment overrides Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2023 •
edited
Loading

Uffizzi Preview deployment-43360 was deleted.

@matthewelwell matthewelwell changed the title improvement: Prepopulate control value on segment overrides feat: prepopulate control value on segment overrides Dec 22, 2023
@matthewelwell matthewelwell added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 68a1c6c Dec 22, 2023
@matthewelwell matthewelwell deleted the chore/pre-populate-control-value-on-segment-overrides branch December 22, 2023 12:31
@dabeeeenster dabeeeenster mentioned this pull request Dec 22, 2023
Merged
@dabeeeenster dabeeeenster mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @matthewelwell