fix(admin/task-processor): handle no task run #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return None for last_run_status if task does not have any run
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gagantrivedi
requested review from
a team and
zachaysan
and removed request for
a team
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3196 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 1062 1062
Lines 32220 32221 +1
=======================================
+ Hits 30938 30939 +1
Misses 1282 1282 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Dec 20, 2023
api/task_processor/admin.py
Outdated
Comment on lines
19
to
22
| def last_run_status(self, instance: RecurringTask) -> Optional[str]: | ||
| return getattr( | ||
| instance.task_runs.order_by("-started_at").first(), "result", None | ||
| ) |
There was a problem hiding this comment.
Suggested change
| def last_run_status(self, instance: RecurringTask) -> Optional[str]: | |
| return getattr( | |
| instance.task_runs.order_by("-started_at").first(), "result", None | |
| ) | |
| def last_run_status(self, instance: RecurringTask) -> Optional[str]: | |
| if last_run := instance.task_runs.order_by("-started_at").first(): | |
| return last_run.result | |
| return None |
Slight preference for this aethetically but have approved regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Return None for last_run status if recurring task runs don't exist
How did you test this code?
By making sure the admin panel for recurring tasks(http://localhost:8000/admin/task_processor/recurringtask/) loads fine
for tasks that don't have any task run