-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new url from role groups #3178
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3178 +/- ##
==========================================
- Coverage 96.11% 96.11% -0.01%
==========================================
Files 1059 1059
Lines 32037 32076 +39
==========================================
+ Hits 30792 30829 +37
- Misses 1245 1247 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is good, but in the future it would be helpful to get a link to the other matching PR in the other repository.
Also, I don't really understand why RolesByGroupViewSet
is importable when the other repository hasn't merged it yet, but I'll leave the merging prioritization up to you.
Good point, I shared all the related PRs in Notion and communicated via Slack, since we don't have other better way to manage subtasks in GitHub. Maybe the next time I will create a specific project for large features, however, part of this work already existed when I started working on it and I didn't realize that it would be necessary to change the API at that moment.
It works maybe because its conditional use? Even when it is a bit counterintuitive that's the way it worked for this kind of multi-repo code in the past. |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
GET: organisations/{organisation_pk}/groups/{group_pk}/roles/
DELETE: organisations/{organisation_pk}/groups/{group_pk}/roles/{id}/
How did you test this code?