feat: Import export environment flags #3161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # frontend/web/components/pages/ImportPage.tsx # frontend/web/components/pages/ProjectSettingsPage.js
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
kyle-ssg
changed the title
kyle-ssg
changed the title
|
Uffizzi Preview |
Co-authored-by: Matthew Elwell <[email protected]>
Co-authored-by: Matthew Elwell <[email protected]>
# Conflicts: # frontend/common/types/requests.ts # frontend/common/types/responses.ts # frontend/web/components/ButterBar.js # frontend/web/components/pages/ImportPage.tsx
|
@kyle-ssg I'm testing this on 2 separate projects. One has a single feature (the exporting project), the other has no features (the import project). I'm not sure if the preview was intended to handle this scenario where there are new features being created, but it's quite confusing that it's not. 
The import file: [
{
"name": "test_feature",
"default_enabled": false,
"is_server_key_only": false,
"initial_value": null,
"value": null,
"type": "unicode",
"enabled": false,
"multivariate": []
}
]Note that continuing with the import worked correctly and the feedback is definitely better. |
# Conflicts: # frontend/common/types/responses.ts # frontend/package-lock.json # frontend/package.json
|
@matthewelwell correct it should be showing new flags, it attempts to filter them whilst filtering existing. This should now be fixed |
matthewelwell
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
How did you test this code?