feat(tasks-processor): Add recurring task to clean up old recurring task runs #3151
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gagantrivedi
changed the title
gagantrivedi
changed the title
gagantrivedi
requested review from
a team and
matthewelwell
and removed request for
a team
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3151 +/- ##
==========================================
+ Coverage 95.95% 96.11% +0.15%
==========================================
Files 1053 1058 +5
Lines 31588 31914 +326
==========================================
+ Hits 30311 30673 +362
+ Misses 1277 1241 -36 ☔ View full report in Codecov by Sentry. |
|
|
| RECURRING_TASK_RUN_RETENTION_DAYS = env.int( | ||
| "RECURRING_TASK_RUN_RETENTION_DAYS", default=30 | ||
| ) |
There was a problem hiding this comment.
Is there a reason not to use the same retention period for both types of task?
There was a problem hiding this comment.
Yeah, I think we probably want to control this independently, e.g: we can probably go with a lower value here because it's not as critical as tasks?
| @register_recurring_task( | ||
| run_every=settings.TASK_DELETE_RUN_EVERY, | ||
| first_run_time=settings.TASK_DELETE_RUN_TIME, | ||
| ) | ||
| def clean_up_old_recurring_task_runs(): | ||
| if not settings.ENABLE_CLEAN_UP_OLD_TASKS: | ||
| return | ||
|
|
||
| now = timezone.now() | ||
| delete_before = now - timedelta(days=settings.RECURRING_TASK_RUN_RETENTION_DAYS) | ||
|
|
||
| RecurringTaskRun.objects.filter(finished_at__lt=delete_before).delete() |
There was a problem hiding this comment.
Is there a reason that we shouldn't just use the same task as the one which removes regular tasks / task runs?
There was a problem hiding this comment.
Yeah, it's because of the name of the task mostly
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required, so people know about the feature!Changes
Add a recurring task to delete recurring task runs older than
RECURRING_TASK_RUN_RETENTION_DAYSHow did you test this code?