fix(sse_recurring_task): reload sse/tasks #3108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to reload sse/tasks after setting RUN_BY_PROCESSOR
because it's imported before (it is loaded as part
of loading installed app) that environment var is set
Call Stack:
```
[0] /home/gagan/Flag/flagsmith/api/manage.py(10)<module>()
-> execute_from_command_line(sys.argv)
[1] /home/gagan/Flag/flagsmith/api/_venv/lib/python3.10/site-packages/django/core/management/__init__.py(419)execute_from_command_line()
-> utility.execute()
[2] /home/gagan/Flag/flagsmith/api/_venv/lib/python3.10/site-packages/django/core/management/__init__.py(395)execute()
-> django.setup()
[3] /home/gagan/Flag/flagsmith/api/_venv/lib/python3.10/site-packages/django/__init__.py(24)setup()
-> apps.populate(settings.INSTALLED_APPS)
[4] /home/gagan/Flag/flagsmith/api/_venv/lib/python3.10/site-packages/django/apps/registry.py(122)populate()
-> app_config.ready()
[5] /home/gagan/Flag/flagsmith/api/_venv/lib/python3.10/site-packages/django/contrib/admin/apps.py(27)ready()
-> self.module.autodiscover()
[6] /home/gagan/Flag/flagsmith/api/_venv/lib/python3.10/site-packages/django/contrib/admin/__init__.py(24)autodiscover()
-> autodiscover_modules('admin', register_to=site)
[7] /home/gagan/Flag/flagsmith/api/_venv/lib/python3.10/site-packages/django/utils/module_loading.py(47)autodiscover_modules()
[15] /home/gagan/Flag/flagsmith/api/environments/admin.py(7)<module>()
-> from .tasks import rebuild_environment_document
-> from sse import (
-> from .sse_service import ( # noqa
-> from sse import tasks
-> @register_task_handler()
```
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3108 +/- ##
==========================================
- Coverage 95.92% 95.91% -0.01%
==========================================
Files 1037 1037
Lines 30882 30900 +18
==========================================
+ Hits 29623 29638 +15
- Misses 1259 1262 +3 ☔ View full report in Codecov by Sentry. |
gagantrivedi
requested review from
a team and
matthewelwell
and removed request for
a team
gagantrivedi
force-pushed
the
fix/register_recurring_task
branch
from
85cf09b to
924bca5
Compare
matthewelwell
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
We need to reload sse/tasks after setting RUN_BY_PROCESSOR because it's imported before (it is loaded as part of loading installed app) that environment var is set
Call Stack:
How did you test this code?
Adds unit test case
Tested manually by running the task processor manually to verify the task was installed, correctly