fix: Environments metadata n+1 for project admin #3101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
A previous feature was incorrectly filtering a queryset for the
get_permitted_environments_for_user
in the case where the user was a project admin, where an early return misses the queryset. This does the check again and if necessary included the sameprefetch_related
.How did you test this code?
I wrote a simple test with verifying the bug visually to ensure that this was the metadata issue reported on Sentry then I fixed it.