Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new endpoint to list summary objects of permission groups #3064

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

matthewelwell
Copy link
Contributor

Changes

Adds a new endpoint to list a summary object for all user groups in an organisation.

How did you test this code?

Added unit tests.

# Conflicts:
#	api/tests/unit/organisations/test_unit_organisations_views.py
#	api/users/views.py
@matthewelwell matthewelwell requested review from a team and khvn26 and removed request for a team November 29, 2023 16:22
Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 7:01pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 7:01pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 7:01pm

@github-actions github-actions bot added the api Issue related to the REST API label Nov 29, 2023
Copy link
Contributor

github-actions bot commented Nov 29, 2023

Uffizzi Preview deployment-41750 was deleted.

@matthewelwell matthewelwell changed the title feat: add new endpoint to list a summary object groups feat: add new endpoint to list summary objects of permission groups Nov 29, 2023
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about it offline, but other than the one blocker the rest of this looks good.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7664ea2) 95.89% compared to head (c4506ad) 95.90%.
Report is 15 commits behind head on main.

❗ Current head c4506ad differs from pull request most recent head 3980872. Consider uploading reports for the commit 3980872 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3064   +/-   ##
=======================================
  Coverage   95.89%   95.90%           
=======================================
  Files        1039     1039           
  Lines       30688    30710   +22     
=======================================
+ Hits        29429    29451   +22     
  Misses       1259     1259           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants