fix: Manage members layout is broken #3058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
front-end
novakzaballa
requested review from
a team and
kyle-ssg
and removed request for
a team
|
Uffizzi Preview |
| @@ -26,7 +26,7 @@ import PageTitle from 'components/PageTitle' | |||
| import { getStore } from 'common/store' | |||
| import { getRoles } from 'common/services/useRole' | |||
|
|
|||
| const widths = [450, 150, 100] | |||
| const widths = [450, 150, 100, 250, 235, 255] | |||
There was a problem hiding this comment.
I'd quite like to understand why we define these widths here rather than just directly in the style objects below.
It also would make sense to my somewhat picky brain if these were ordered, either smallest to largest or largest to smallest, I'm not that fussy!
There was a problem hiding this comment.
It seems that initially this array was used to give sizes to the panelSearch component, as I worked on that component I added those values to the array.
Re-ordered.
|
I have tested this via the preview and it looks good to me, but I've added a comment on the implementation. |
matthewelwell
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Before:
Now:
How did you test this code?