fix: Refactor existing Chargebee webhooks for subscriptions #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
matthewelwell
approved these changes
Nov 29, 2023
| @@ -662,12 +668,13 @@ def test_when_subscription_is_cancelled_then_cancellation_date_set_and_alert_sen | |||
| ): | |||
| # Given | |||
| cancellation_date = datetime.now(tz=UTC) + timedelta(days=1) | |||
| current_term_end = int(datetime.timestamp(cancellation_date)) | |||
There was a problem hiding this comment.
I'm curious as to why this had to change as part of this PR?
There was a problem hiding this comment.
Because the Chargebee API sends unix time in integer seconds, not milliseconds or microseconds. So to go through the API we need to fix the integer resolution to get through the serializer.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3047 +/- ##
==========================================
- Coverage 95.89% 95.89% -0.01%
==========================================
Files 1039 1039
Lines 30688 30721 +33
==========================================
+ Hits 29429 29459 +30
- Misses 1259 1262 +3 ☔ View full report in Codecov by Sentry. |
zachaysan
deleted the
fix/refactor_existing_webhooks_for_subscriptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Taking direction from earlier work, I clustered these functionalities together with the other pieces of isolated webhook modules. The basic patterns are the same, although this instance the serializers were more involved. I took a look at the Chargebee webhooks response document and tried to match things up as best as I could.
How did you test this code?
The existing test base has good coverage of this part. I was able to add alterations to the test base where deviations had come into play based off of what is in the serializers. For example, the chargebee unixtimestamp is in integer format, not floats, so these and other things were needed to be fixed.