-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rely on Flagsmith Engine for segment evaluation, avoid N+1 queries #3038
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
9199e9b
to
8c0b0b9
Compare
Uffizzi Preview |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3038 +/- ##
==========================================
+ Coverage 95.73% 95.88% +0.14%
==========================================
Files 1046 1045 -1
Lines 30859 30677 -182
==========================================
- Hits 29544 29414 -130
+ Misses 1315 1263 -52 ☔ View full report in Codecov by Sentry. |
@matthewelwell This is correct. I'll prefer to merge #3039 first and then this one. |
Actually let's just merge this one, there's no value in doing them separately. |
8c0b0b9
to
5cd1316
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
SDKIdentitiesDeprecated
. This solves the traits N+1 query.How did you test this code?