-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: opening the flag panel shifts the main table slightly #2994
fix: opening the flag panel shifts the main table slightly #2994
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@MatheusLasserre is attempting to deploy a commit to the Flagsmith Team on Vercel. A member of the Team first needs to authorize it. |
This appears to be fixing the same issue as in #2991 but with a different fix implementation. I'm not sure on the benefits / implications of one or the other here. |
Uffizzi Preview |
This one looks cleaner! Just testing |
Thanks! |
You're welcome! |
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Removed the "!important" from padding-right on class "modal-open", which was forcing the browser to increase the page width when the scrollbar disappears.
The issue was that every time the page had a scroll-bar, opening a modal causes a layout shift, since it makes the scroll-bar disappears. So it was not only on the feature flag modal, but all of them.
Fixes #2984
How did you test this code?