Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move tests to unit #2987

Merged
merged 5 commits into from
Nov 16, 2023
Merged

fix: Move tests to unit #2987

merged 5 commits into from
Nov 16, 2023

Conversation

zachaysan
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Moved and refactored tests in the app, app_analytics, and audit directories to the unit test directory. Note that @matthewelwell asked that I don't refactor tests as I move them since it complicates merges, so this is an exception.

How did you test this code?

Ran the tests locally after refactoring and moving.

Copy link

vercel bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 7:48pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 7:48pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 7:48pm

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Uffizzi Preview deployment-40926 was deleted.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6976f81) 95.57% compared to head (b5d7dc7) 95.57%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2987      +/-   ##
==========================================
- Coverage   95.57%   95.57%   -0.01%     
==========================================
  Files        1015     1015              
  Lines       29481    29480       -1     
==========================================
- Hits        28176    28175       -1     
  Misses       1305     1305              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@novakzaballa novakzaballa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaysan zachaysan added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit 43caad8 Nov 16, 2023
@zachaysan zachaysan deleted the fix/move_tests branch November 16, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants