fix: Excessive 404s on subscription metadata #2985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingChanges
Full ticket context here, in short, subscriptions were added by default to organisations and the metadata endpoint was bypassing the free accounts because it relied on a method previously called
has_subscription
to 404 requests. Changes introduced:has_paid_subscription
which is closer to the intent, but still a little confusing since it includes paid subscriptions that have been canceled. I added a comment on the method, but a better method name would be even better.How did you test this code?
I updated the one test that was designed for the 404 page and ran tests from around where the code has changed.