Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Logic in segment overrides readonly with the manage_segment_overrides permission #2973

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: Logic in segment overrides readonly with the manage_segment_overrides permission #2973

merged 1 commit into from
Nov 14, 2023

Conversation

novakzaballa
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Invert a boolean value when the user has manage_segment_overrides permission is not readOnly

How did you test this code?

  • Go to edit feature modal.
  • Select the Segment Overrides Tab.
  • If the user has manage_segment_overrides permission can create, update, and delete a segment override.
  • if the user does not have permission Segment override component is readOnly

@vercel Vercel
Copy link

vercel bot commented Nov 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 14, 2023 7:02pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 7:02pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview Nov 14, 2023 7:02pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Nov 14, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

Uffizzi Preview deployment-40745 was deleted.

zachaysan
zachaysan approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@zachaysan zachaysan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@novakzaballa novakzaballa added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit 37879b2 Nov 14, 2023
@novakzaballa novakzaballa deleted the fix/logic-in-the-segment-overrides-readonly-with-the-manage-segment-overrides-permission branch November 14, 2023 19:28
@dabeeeenster dabeeeenster mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaysan zachaysan zachaysan approved these changes

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novakzaballa @zachaysan