feat: Remove all but first admin when subscription has reached cancellation date #2965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2965 +/- ##
=======================================
Coverage 95.54% 95.55%
=======================================
Files 1013 1014 +1
Lines 29331 29393 +62
=======================================
+ Hits 28025 28087 +62
Misses 1306 1306 ☔ View full report in Codecov by Sentry. |
matthewelwell
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingChanges
Added code to existing cancellation workflow to limit the seats to a sole admin once the subscription cancellation date has finally been reached.
How did you test this code?
Two new tests. Once that goes through the web request for cancellations that are immediate, and another for any that have a cancellation date in the future. I also read through a lot of code around subscriptions to see if there were other areas that could benefit from delayed processing of cancelation but I didn't find any sure contenders.